-
Notifications
You must be signed in to change notification settings - Fork 4k
Lazy load OpenAPI styles and remove Tailwind Typography #3883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy load OpenAPI styles and remove Tailwind Typography #3883
Conversation
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
e0b9bba to
8a6e774
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request removes the @tailwindcss/typography dependency and replaces it with a custom CSS-only typography implementation. It also optimizes OpenAPI styles by lazy loading them through CSS imports rather than multiple component-level imports.
Changes:
- Removed
@tailwindcss/typographypackage dependency and replaced with custom prose.css implementation - Migrated OpenAPI component styles from individual imports to centralized CSS import
- Updated Tailwind class syntax from
prose-*:modifierto[&_*]:modifierpattern for consistency with Tailwind v4
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/gitbook/tailwind.config.ts | Removed typography plugin import and registration |
| packages/gitbook/src/components/RootLayout/prose.css | Added custom CSS-only typography implementation with @Utility directives |
| packages/gitbook/src/components/RootLayout/globals.css | Added import for the new prose.css file |
| packages/gitbook/src/components/DocumentView/OpenAPI/style.css | Updated class syntax to use arbitrary selectors and imported scalar.css |
| packages/gitbook/src/components/DocumentView/OpenAPI/context.tsx | Removed scalar.css import (moved to style.css) |
| packages/gitbook/src/components/DocumentView/OpenAPI/OpenAPIWebhook.tsx | Removed duplicate style imports and reorganized imports |
| packages/gitbook/src/components/DocumentView/OpenAPI/OpenAPISchemas.tsx | Removed duplicate style imports and reorganized imports |
| packages/gitbook/src/components/DocumentView/OpenAPI/OpenAPIOperation.tsx | Removed duplicate style imports and reorganized imports |
| packages/gitbook/package.json | Removed @tailwindcss/typography dependency |
| bun.lock | Updated lock file to reflect removed dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.